Skip to content
This repository has been archived by the owner on Jan 22, 2022. It is now read-only.

Dry and test reducers #25

Open
effa opened this issue Aug 28, 2016 · 0 comments
Open

Dry and test reducers #25

effa opened this issue Aug 28, 2016 · 0 comments
Assignees
Labels
Milestone

Comments

@effa
Copy link
Member

effa commented Aug 28, 2016

  • factor out dispatching actions from reducers
  • factor out common code from solve_task_instance and give_up_task_instance
  • factor out common code from increase_[started|given_up|solved]_count (maybe just one function with partial application in the stats reducer)
  • (maybe even creating/updating entities)

Related question: how to organize/split reducers.py? different pieces: top reducers, delegated functions (by actions, by substate - 2 orthogonal criteria), WORLD_REDUCER (with combine reducers).

@effa effa added the question label Aug 28, 2016
@effa effa added this to the Next tasks milestone Aug 28, 2016
@matej-vanek matej-vanek self-assigned this Mar 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants