Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up linting infrastructure and fix errors and inconsistencies #18

Open
effa opened this issue Jan 1, 2017 · 0 comments
Open

Set up linting infrastructure and fix errors and inconsistencies #18

effa opened this issue Jan 1, 2017 · 0 comments
Milestone

Comments

@effa
Copy link
Member

effa commented Jan 1, 2017

For setup and rules, see https://github.com/adaptive-learning/flocs-visual-components (package.json, webpack config and .eslintrc.json).

The automatic linting is extremely useful for consistent code, and it also teaches how to write good ES6/react code. Currently there are many inconsistencies (mixing different quotes, 2 and 4 spaces, jsx extension for files without JSX, unused imports and variables, etc. - just see what the linter says). (Side note: I would also avoid inconsistent names for different thing, e.g. sthEnv vs. sthEnvironment, pick one and stick with that.)

@effa effa modified the milestone: Next Tasks Feb 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant