Detect code in pre-tag using indicators and fix code formatting issues #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steineggerroland
force-pushed
the
master
branch
from
7bb8466 to
25085f7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #776 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 21 21
Lines 3587 3594 +7
=======================================
+ Hits 3561 3568 +7
Misses 26 26 ☔ View full report in Codecov by Sentry. |
adbar
reviewed
Jan 14, 2025
|
Hi @steineggerroland, thanks for the PR, could you please address the issue above? The rest looks fine! |
steineggerroland
force-pushed
the
master
branch
from
3e4fb16 to
4981d37
Compare
steineggerroland
force-pushed
the
master
branch
from
4981d37 to
cb70ec4
Compare
|
@steineggerroland Thanks for taking the time to do the tests! I'm fine with your solution, there is a remaining problem with mypy on Python 3.13 though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tackles #775 and an issue mentioned in #553.
Regarding #775 which mentions problems in detecting code blocks using just
<pre>-tag:convert_quotesis extended so that it uses a list of indicators to verify, if the element is a quote or a code block. If a code indicator is detected within the element, its expected to be a code block.Suggested indicators to start with are:
{,(",(',\nRegarding #553:
Quote: "btw. here is another bug (maybe) when extracting inline code block, a redundant '\n' was added after a inline code block now result"
I changed how the line break is added to
codeblocks. I removedcodeas "NEWLINE_ELEMS" which currently leads to the line break. Instead the line break is now added when convertingcodeto text if its a multiline block.While fixing this issue another problem arose. A space is added after inline code. I fixed this issue making
codea "SPECIAL_FORMATTING" element.Issue with breaking code is tackled, too.
Line breaks are converted to \n within code blocks. There might be an issue with spaces which definitely needs to be addressed as mentioned in #553.