Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Drop CustomerPassword #1053

Closed
c0rydoras opened this issue Apr 18, 2024 · 0 comments · Fixed by #1062
Closed

Drop CustomerPassword #1053

c0rydoras opened this issue Apr 18, 2024 · 0 comments · Fixed by #1062
Labels
quality security Pull requests that address a security vulnerability

Comments

@c0rydoras
Copy link
Contributor

c0rydoras commented Apr 18, 2024

S324:

timed/subscription/admin.py:27:38: S324 Probable use of insecure hash functions in hashlib: md5 | 25 | password = self.cleaned_data.get("password") 26 | if password is not None: 27 | self.instance.password = hashlib.md5(password.encode()).hexdigest() | ^^^^^^^^^^^ S324 28 | return super().save(commit=commit) |

class CustomerPassword(models.Model):
    """Password per customer used for login into SySupport portal.

    Password are only hashed with md5. This model will be obsolete
    once customer center will go live.
    """

Can this be dropped, respectively ignored and dropped in a separate PR?
Since https://github.com/adfinis/customer-center does exist

I'm not 100% if this is still in use or not. It looks like it was part of the old SySupport portal and might have been replaced with a proper solution when the portal was migrated to being an Ember based frontend.

If this is in fact the case then we should create an issue to track the codes removal. Maybe @winged or @trowik know if it's still needed?

I'm also not 100% sure, but I'd say it's safe to remove it in another PR.

Originally posted by @trowik in #1049 (comment)

@hairmare hairmare added security Pull requests that address a security vulnerability quality labels Apr 18, 2024
@c0rydoras c0rydoras linked a pull request Apr 22, 2024 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
quality security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants