Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR]: get rid of adcssy.scss #256

Closed
1 task done
c0rydoras opened this issue Jun 7, 2024 · 3 comments · Fixed by #483
Closed
1 task done

[REFACTOR]: get rid of adcssy.scss #256

c0rydoras opened this issue Jun 7, 2024 · 3 comments · Fixed by #483
Labels
frontend This issue or pull request is frontend related refactor This issue or pull request discusses refactoring

Comments

@c0rydoras
Copy link
Collaborator

What to refactor

stuff in adcssy.scss

Why refactor it

its not maintainable

How to refactor it

  1. find replacement e.g. uikit which we use in our other projects
  2. rewrite easy parts to uikit
  3. ensure there are no visual regressions
  4. merge, be happy, more maintainable

Required

  • I have checked past issues to ensure that this isn't a duplicate.
@c0rydoras c0rydoras added refactor This issue or pull request discusses refactoring frontend This issue or pull request is frontend related labels Jun 7, 2024
@c0rydoras c0rydoras added this to timed Jun 7, 2024
@c0rydoras c0rydoras moved this to 🆕 In Discussion in timed Jun 7, 2024
@MitanOmar
Copy link
Member

@c0rydoras what are you trying to fix ?

@c0rydoras
Copy link
Collaborator Author

Timed

@derrabauke
Copy link
Contributor

Very good point! Let's do that. You could use https://github.com/garris/ember-backstop or https://github.com/percy/percy-ember to test for visual regression. It runs locally as well, I you don't want to set it up permanently.

@c0rydoras c0rydoras moved this from 🆕 In Discussion to 📋 Backlog in timed Jun 7, 2024
@c0rydoras c0rydoras linked a pull request Oct 2, 2024 that will close this issue
refactor: frontend #483
Merged
@c0rydoras c0rydoras moved this from 📋 Backlog to 🏗 In progress in timed Oct 25, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in timed Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend This issue or pull request is frontend related refactor This issue or pull request discusses refactoring
Projects
timed
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: frontend c0rydoras/timed
3 participants
@derrabauke @MitanOmar @c0rydoras