Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DebugStrOut - flush parameter type differs in declaration,documentation and usages #34

Open
MScieburakoADVA opened this issue May 21, 2021 · 1 comment

Comments

@MScieburakoADVA
Copy link

In stp.h flush parameter is uint:

typedef void  (*STP_CALLBACK_DEBUG_STR_OUT)  (const struct STP_BRIDGE* bridge, int portIndex, int treeIndex, const char* nullTerminatedString, unsigned int stringLength, unsigned int flush);

In documentation StpCallback_DebugStrOut.html flush is bool type.

All usages inside stp_log.cpp provide true/false as flush argument

@adigostin adigostin added this to the 3.0 milestone May 21, 2021
@adigostin
Copy link
Owner

adigostin commented May 21, 2021

Thanks for reporting this. It will be fixed in a 3.0, when I will change all types to those from stdint.h and stdbool.h.

(When I started working on this library, it had to work on IAR 5.x and have a C-only interface; back then IAR had some issues with stdint.h, that's why I limited myself to types built into the C language; things got messy later when I had to support GCC 6.x and clang.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants