Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate jQuery dependency #291

Open
gknobloch opened this issue Nov 12, 2021 · 3 comments
Open

Eliminate jQuery dependency #291

gknobloch opened this issue Nov 12, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@gknobloch
Copy link
Member

Expected Behaviour

No need for jQuery dependency

Actual Behaviour

https://github.com/adobe/aem-guides-wknd/search?q=jquery

Reproduce Scenario (including but not limited to)

N/A

Steps to Reproduce

N/A

Platform and Version

N/A

Sample Code that illustrates the problem

See Github search

Logs taken while reproducing problem

N/A

@godanny86 godanny86 self-assigned this Nov 12, 2021
@godanny86
Copy link
Contributor

@gknobloch I can take a stab at this. IIRC it was primarily being used for the mobile nav. I still think its nice to show an example of a 3rd party library so may choose to implement with: https://slideout.js.org/. Unless you have any ideas / recommendations...

@keepthebyte
Copy link
Collaborator

The main goal is to remove Javascript library dependencies to improve LCP (Largest Contentful Paint) on mobile devices

@keepthebyte keepthebyte added the enhancement New feature or request label Nov 13, 2021
@Tylopilus
Copy link

Is this still needed as clientlibs now load async? It still would be nice to ditch jQuery. As this a simple toggle I would not encourage to use any library but implement this with simple js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants