Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moment converts to proxy on changeset creation #629

Closed
bgolla opened this issue Jan 18, 2022 · 4 comments
Closed

moment converts to proxy on changeset creation #629

bgolla opened this issue Jan 18, 2022 · 4 comments

Comments

@bgolla
Copy link

bgolla commented Jan 18, 2022

Version

"ember-changeset": "^4.0.0-beta.1",
"ember-changeset-validations": "4.0.0-beta.2",

Test Case

Steps to reproduce

let x = new Changeset({ foo: moment() });
console.log(x.foo instanceof moment); // returns false
console.log(x.foo); //returns Proxy {changes: {…}, content: Moment, proxy: Proxy, safeGet: ƒ, isObject: ƒ, …}

Expected Behavior

Returns moment instance instead

Actual Behavior

Returns Proxy

@snewcomer
Copy link
Collaborator

@bgolla Thank you! Is there a minimal test and failing assertion (using this repository's test suite) that shows this bug?

@snewcomer
Copy link
Collaborator

@bgolla #636 (comment)

@snewcomer
Copy link
Collaborator

snewcomer commented Mar 12, 2022

#628 (comment)

Lmk if you have any other comments!

@veelci
Copy link

veelci commented Nov 29, 2023

@snewcomer Why did you close this? Nothing has been done to fix this issue.

veelci added a commit to aboveproperty/ember-changeset that referenced this issue Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants