-
-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove native compiler dependency in system tests #5965
Comments
@annaibm could you take a look at this issue? Thanks |
In OpenJDK I see FYI |
- Remove com.test.jlink to eliminate xlC dependency in system tests related:adoptium/aqa-tests#5965 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Remove com.test.jlink to eliminate xlC dependency in system tests related:adoptium/aqa-tests#5965 Signed-off-by: Anna Babu Palathingal <[email protected]>
@llxia Draft PR: adoptium/aqa-systemtest#498 Had to exclude the following tests as shown in the Draft PR: adoptium/aqa-tests#5992 as the sanity.system test failed for the jlink tests. Sanity.system test failure (without excluding jlink tests): Disabled Tests: (can remove the tests if its not needed) Test run after exclusions: Sanity.system test run passed |
I believe we should also remove Jlink_ReqMod,Jlink_AddMLimitM and Jlink_GenOpt from playlist.xml |
- Remove the Jlink tests `Jlink_ReqMod`,`Jlink_AddMLimitM`,`Jlink_GenOpt` as the com.test.jlink from system test is removed. related: adoptium#5965 Signed-off-by: Anna Babu Palathingal <[email protected]>
* Remove com.test.jlink to eliminate xlC dependency - Remove com.test.jlink to eliminate xlC dependency in system tests related:adoptium/aqa-tests#5965 Signed-off-by: Anna Babu Palathingal <[email protected]> * Removed the build-natives target * Removed setup-native-build-command --------- Signed-off-by: Anna Babu Palathingal <[email protected]>
- Remove the Jlink tests `Jlink_ReqMod`,`Jlink_AddMLimitM`,`Jlink_GenOpt` as the com.test.jlink from system test is removed. related: #5965 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Remove com.test.jlink to eliminate xlC dependency in system tests - Remove the build-natives target - Removed setup-native-build-command target related:adoptium/aqa-tests#5965 Signed-off-by: Anna Babu Palathingal <[email protected]>
Native compilation in system tests resulted in many complications when setting up the testing environment.
For example, we need to have the correct compiler installed.
xlC
is /opt/IBM/xlC/13.1.3/bin (we no longer support it), but it's on the path.xlclang
is /opt/IBM/xlC/16.1.0/bin, which isn't on the path. Also, Visual Studio is expected on Windows with specific versions/path.Talked with @pshipton , and we think we should simplify system tests by removing the native compiler dependency.
ToDo:
If this test is important, we can contribute it to OpenJDK if needed.
SharedClassesAPI
native code into OpenJ9, and stop building it in the tests.build-natives-xxx
should be empty)Inform infra team to remove native compiler as part of the test env setup requirement.We still need it for non-system tests.The text was updated successfully, but these errors were encountered: