Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove native compiler dependency in system tests #5965

Open
4 tasks
llxia opened this issue Feb 20, 2025 · 4 comments
Open
4 tasks

Remove native compiler dependency in system tests #5965

llxia opened this issue Feb 20, 2025 · 4 comments

Comments

@llxia
Copy link
Contributor

llxia commented Feb 20, 2025

Native compilation in system tests resulted in many complications when setting up the testing environment.

For example, we need to have the correct compiler installed. xlC is /opt/IBM/xlC/13.1.3/bin (we no longer support it), but it's on the path. xlclang is /opt/IBM/xlC/16.1.0/bin, which isn't on the path. Also, Visual Studio is expected on Windows with specific versions/path.

Talked with @pshipton , and we think we should simplify system tests by removing the native compiler dependency.

ToDo:

  • Remove com.test.jlink from system test https://github.com/adoptium/aqa-systemtest/tree/master/openjdk.test.modularity/src/tests/com.test.jlink.
    If this test is important, we can contribute it to OpenJDK if needed.
  • Move SharedClassesAPI native code into OpenJ9, and stop building it in the tests.
  • Ensure we do not have any other native compilation in system tests (i.e., all build-natives-xxx should be empty)
  • Inform infra team to remove native compiler as part of the test env setup requirement. We still need it for non-system tests.
@llxia
Copy link
Contributor Author

llxia commented Feb 20, 2025

@annaibm could you take a look at this issue? Thanks

@pshipton
Copy link
Contributor

pshipton commented Feb 20, 2025

In OpenJDK I see test/jdk/tools/jlink, not sure if we are running these tests.

FYI
/opt/IBM/xlC/16.1.0/bin has both xlC and xlclang. OpenJ9 builds no longer use xlC, or 13.1.3 compilers.
13.1.3 is on the path on some machines, but since AIX 7.3 doesn't support it, I expect 16.1.0 is on the path on AIX 7.3 machines.

annaibm added a commit to annaibm/aqa-systemtest that referenced this issue Feb 21, 2025
- Remove com.test.jlink to eliminate xlC dependency in system tests

related:adoptium/aqa-tests#5965
Signed-off-by: Anna Babu Palathingal <[email protected]>
annaibm added a commit to annaibm/aqa-systemtest that referenced this issue Feb 27, 2025
- Remove com.test.jlink to eliminate xlC dependency in system tests

related:adoptium/aqa-tests#5965
Signed-off-by: Anna Babu Palathingal <[email protected]>
@annaibm
Copy link
Contributor

annaibm commented Feb 28, 2025

@llxia
Removed the com.test.jlink from the system test com.test.jlink directory and made related build.xml changes that depended on com.test.jlink.

Draft PR: adoptium/aqa-systemtest#498

Had to exclude the following tests as shown in the Draft PR: adoptium/aqa-tests#5992 as the sanity.system test failed for the jlink tests.

Sanity.system test failure (without excluding jlink tests):
Grinder #48246

Disabled Tests: (can remove the tests if its not needed)
TESTLIST=Jlink_ReqMod,Jlink_AddMLimitM,Jlink_GenOpt

Test run after exclusions:
Grinder #48400

Sanity.system test run passed
Grinder #48446

@llxia
Copy link
Contributor Author

llxia commented Mar 1, 2025

I believe we should also remove Jlink_ReqMod,Jlink_AddMLimitM and Jlink_GenOpt from playlist.xml

annaibm added a commit to annaibm/aqa-tests that referenced this issue Mar 3, 2025
- Remove the Jlink tests `Jlink_ReqMod`,`Jlink_AddMLimitM`,`Jlink_GenOpt`
 as the com.test.jlink from system test is removed.

 related: adoptium#5965

 Signed-off-by: Anna Babu Palathingal <[email protected]>
pshipton pushed a commit to adoptium/aqa-systemtest that referenced this issue Mar 5, 2025
* Remove com.test.jlink to eliminate xlC dependency

- Remove com.test.jlink to eliminate xlC dependency in system tests

related:adoptium/aqa-tests#5965
Signed-off-by: Anna Babu Palathingal <[email protected]>

* Removed the build-natives target

* Removed setup-native-build-command

---------

Signed-off-by: Anna Babu Palathingal <[email protected]>
pshipton pushed a commit that referenced this issue Mar 6, 2025
- Remove the Jlink tests `Jlink_ReqMod`,`Jlink_AddMLimitM`,`Jlink_GenOpt`
 as the com.test.jlink from system test is removed.

 related: #5965

 Signed-off-by: Anna Babu Palathingal <[email protected]>
annaibm added a commit to annaibm/aqa-systemtest that referenced this issue Mar 6, 2025
- Remove com.test.jlink to eliminate xlC dependency in system tests
- Remove the build-natives target
- Removed setup-native-build-command target

related:adoptium/aqa-tests#5965
Signed-off-by: Anna Babu Palathingal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

3 participants