create a json validation schema for the project. #1268
Conversation
|
How to apply the json config: YAML validation with JSON Schema in IntelliJ |
There was a problem hiding this comment.
This looks helpful. Is this schema written by hand or generated somehow?
If the schema can be generated, we should add a script and document the generation process.
Also we should update the examples (or add a new one) yaml files that shows how to use the json schema reference with intellij / vscode, e.g. as discussed here:
https://github.com/orgs/adorsys/projects/5/views/1?pane=issue&itemId=91205605&issue=adorsys%7Ckeycloak-config-cli%7C1122
| @@ -0,0 +1,14654 @@ | |||
| { | |||
| "$schema": "http://json-schema.org/draft-06/schema#", | |||
| "$ref": "#/definitions/Welcome6", | |||
There was a problem hiding this comment.
What is the meaning of the Welcome reference? Shouldn't it be named differently, e.g. realmConfig?
Co-authored-by: Thomas Darimont <[email protected]>
Co-authored-by: Thomas Darimont <[email protected]>
|
|
Okay @thomasdarimont. I will work on that. |
What this PR does / why we need it:
Which issue this PR fixes (optional, in `fixes #1122. will close that issue when PR gets merged): fixes #1122
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR