Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Allow repeating the search with a different limit #263

Open
neongreen opened this issue May 7, 2019 · 0 comments
Open

Allow repeating the search with a different limit #263

neongreen opened this issue May 7, 2019 · 0 comments

Comments

@neongreen
Copy link
Member

neongreen commented May 7, 2019

Currently we limit the search to 1000 matches. It saves our resources when the user is not interested in seeing all the matches (I'd bet that most of the time people only care about the first page).

However, sometimes the user needs to know exactly how many matches there are (e.g. to compare two alternatives), and then the 1000+ restriction is inconvenient. We should allow repeating the search with a higher match limit (e.g. 10000+) when the user gets 1000+ matches.

  • Add a query parameter ?limit=... that is set to 1000 by default
  • Add a config option for the maximum allowed limit
  • When the ?limit is higher than maximum, return 403 forbidden
  • When the limit is exceeded, show a button to the user ("repeat with limit = 10000")
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant