Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't autorestart PHPFPM on Makefile #12

Open
PixiBixi opened this issue Dec 4, 2023 · 1 comment
Open

Don't autorestart PHPFPM on Makefile #12

PixiBixi opened this issue Dec 4, 2023 · 1 comment

Comments

@PixiBixi
Copy link

PixiBixi commented Dec 4, 2023

HI,

IMO, you shouldn't apply auto restart of FPM (or apache) for multiple reasons :

  • To fetch your PHP version, you use php -v, it assumes default CLI version is the same of FPM
  • You write extension=libaerospike directly on php.ini, usually, we prefer splitting it into subfiles
  • And above all, we don't want to restart in an unexpected way our FPM process.

I suggest you to write a message in the user terminal saying aerospike lib isn't enabled until a restart is done

Best,

Jérémy

@thias thias mentioned this issue Dec 12, 2023
@vmsachin
Copy link
Collaborator

Hi @PixiBixi , we are looking into the best way to refactoring the entire build process. I will add the message if we add the restart in the new build process. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants