Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested improvements for IsPullback #334

Open
JacquesCarette opened this issue Jan 3, 2022 · 4 comments
Open

Suggested improvements for IsPullback #334

JacquesCarette opened this issue Jan 3, 2022 · 4 comments

Comments

@JacquesCarette
Copy link
Collaborator

(from @sergey-goncharov ):
I would suggest:

  1. move the "unique" field to the bottom. It is the most sophisticated property, and must logically be
    the last one (this should more generally be taken as a rule for all limits and colimits).

  2. I suggest to replace 'unique' with what is currently derived as 'unique-diagram'. This would make
    everything symmetric, and I would expect, in most cases, it would be easier to prove that something is a
    pullback.

As a bonus, uniqueness will no longer depend on 'eq : f ∘ h₁ ≈ g ∘ h₂', which is really not needed for
it, but which gets in way.

@TOTBWF
Copy link
Collaborator

TOTBWF commented Jan 5, 2022

These all seem like great changes!

When we do this, we should probably update Pushout as well.

@jacquescomeaux
Copy link
Contributor

This seems pretty straightforward. Are these changes still wanted?

@sergey-goncharov
Copy link
Collaborator

This seems pretty straightforward. Are these changes still wanted?

I think so.

@JacquesCarette
Copy link
Collaborator Author

Some low-hanging fruit just need people with spare cycles!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants