New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Int ? #838

Open

thomas-lamiaux opened this issue Jun 5, 2022 · 1 comment

Contributor

thomas-lamiaux commented Jun 5, 2022

Currently in Int there is a bunch of properties like +Comm that maybe should be hidden.
Indeed they are often in double with opening a RingStr

Contributor Author

thomas-lamiaux commented Jun 16, 2022

We talked about it, the idea would be to

Put those lemma in named module so that people have to open it to acces it.
Add comment on top of the concern files saying not to use them but to use the following instances [...] instead .
For instance the CommRing for Int
- Add a more general comment in contributing, possibly completing the current one on modules.
The concerned files would be at least Int and Nat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment