Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warm start classes #153

Open
1 of 2 tasks
jmirabel opened this issue Jan 24, 2025 · 3 comments
Open
1 of 2 tasks

Warm start classes #153

jmirabel opened this issue Jan 24, 2025 · 3 comments

Comments

@jmirabel
Copy link
Contributor

jmirabel commented Jan 24, 2025

I have two remarks regarding the warm start classes.

  • WarmStartReference.generate calls rnea for each point. We have a performance loss here. We only need to use RNEA algo once for each point regardless of how many times they are used by successive generate calls.
  • WarmStartBase.generate should provide as a default behavior a warm start based on the previous solution.

The second point has a rather high priority to me as it is what I think we need for MPC with collision avoidance.

EDIT: The second point will be handled in #157

@jmirabel
Copy link
Contributor Author

FYI @kzorina @MaximilienNaveau

@MaximilienNaveau
Copy link
Collaborator

The second point I disagree. We should provide such a warmstart but not as base. As an educated guess from the one picking the warmstart they want.
Hence I would suggest to implement a daughter class that implements such warmstart.

@jmirabel
Copy link
Contributor Author

I have played with the second point using a child class of WarmStartBase. This is implemented in #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants