Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pace-util: quantity attrs inaccessible #177

Open
brianhenn opened this issue May 3, 2022 · 1 comment
Open

pace-util: quantity attrs inaccessible #177

brianhenn opened this issue May 3, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@brianhenn
Copy link
Contributor

brianhenn commented May 3, 2022

pace.util.Quantity has an attribute _attrs that isn't accessible via instantiation or public setter (though it has a getter). Because Quantity is used in the fv3net integration for writing zarrs, this means that fv3net is currently using private API to write a zarr with array attributes. In the spirit of making the fv3net -pace.util integration more robust, seems like we should add a setter for Quantity._attrs, or go the other way and get rid of Quantity._attrs entirely.

@mcgibbon
Copy link
Collaborator

mcgibbon commented May 9, 2022

I think we originally had an attrs argument to the constructor for Quantity, but removed it for reasons I don't remember. We could add it back if we want to use it for writing to zarr.

@FlorianDeconinck FlorianDeconinck added the enhancement New feature or request label Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants