From a229e06e34038b1b4826ee3f39627a64b924f8c4 Mon Sep 17 00:00:00 2001 From: nicl-nno Date: Fri, 15 Nov 2024 21:46:40 +0300 Subject: [PATCH] Code review fixes --- .../opt_history_objects/opt_history.py | 17 ----------------- golem/core/optimisers/optimizer.py | 4 ++-- 2 files changed, 2 insertions(+), 19 deletions(-) diff --git a/golem/core/optimisers/opt_history_objects/opt_history.py b/golem/core/optimisers/opt_history_objects/opt_history.py index 76837ae1..dafc84ca 100644 --- a/golem/core/optimisers/opt_history_objects/opt_history.py +++ b/golem/core/optimisers/opt_history_objects/opt_history.py @@ -174,23 +174,6 @@ def all_historical_quality(self, metric_position: int = 0) -> List[float]: def show(self): return OptHistoryVisualizer(self) - # def analyze_online(self, url='https://fedot.onti.actcognitive.org'): - # case_id = FILE_NAME.replace('.json', '') + str(uuid4()) - # history_url = f'{DOMAIN}/ws/sandbox/custom_{case_id}/history' - # post_url = f"{DOMAIN}/api/showcase/add" - # - # history_json = json.load(open(BASE_PATH.joinpath(FILE_NAME))) - # new_case = { - # 'case': { - # 'case_id': case_id, - # }, - # 'history': history_json - # } - # response = requests.post(post_url, json=new_case) - # - # print(response.text, response.status_code, ) - # print(f'IMPORTANT! Save this url.\n{history_url}') - def get_leaderboard(self, top_n: int = 10) -> str: """ Prints ordered description of the best solutions in history diff --git a/golem/core/optimisers/optimizer.py b/golem/core/optimisers/optimizer.py index a6cfeae4..23ec1cb1 100644 --- a/golem/core/optimisers/optimizer.py +++ b/golem/core/optimisers/optimizer.py @@ -109,10 +109,10 @@ class GraphOptimizer: def __init__(self, objective: Objective, initial_graphs: Optional[Sequence[Union[Graph, Any]]] = None, - # TODO: rename params to avoid confusion requirements: Optional[OptimizationParameters] = None, graph_generation_params: Optional[GraphGenerationParams] = None, - graph_optimizer_params: Optional[AlgorithmParameters] = None): + graph_optimizer_params: Optional[ + AlgorithmParameters] = None): # check if correct for inherited optimizers self.log = default_log(self) self._objective = objective initial_graphs = graph_generation_params.adapter.adapt(initial_graphs) if initial_graphs else None