You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
this is a very broad scope - probably needs a review of most aiomysql code to compare with pymysql code.
a good step to start should be porting all PyMySQL test cases to see which issues we can already identify from missing test cases.
an alternative could be to review all PyMySQL commits/changes between the previously used version and the current latest version: PyMySQL/PyMySQL@v0.9.3...v1.0.2
this may however missing ports of older changes, I don't know how close attention was paid to this before.
The text was updated successfully, but these errors were encountered:
I'm not sure if there's an easy way to structure or coordinate this work, I'd be happy to hear suggestions.
One thing that should be possible to do relatively independently would be reviewing the test cases, looking into what we may be missing on our side and whether the existing test cases also test the same things.
Ensuring having all test cases on our end might also help catching some missing ports due to test failures.
Outside of tests it's probably be harder to isolate individual changes.
I'd probably just pick different methods and compare the internal logic to PyMySQL's logic, even though it is most likely quite cumbersome.
There's also still some cleanup that should be done unrelated to syncing up with PyMySQL, such as context manager simplification like aio-libs/aiopg#813, which would make the code easier to follow.
this is a very broad scope - probably needs a review of most aiomysql code to compare with pymysql code.
a good step to start should be porting all PyMySQL test cases to see which issues we can already identify from missing test cases.
an alternative could be to review all PyMySQL commits/changes between the previously used version and the current latest version: PyMySQL/PyMySQL@v0.9.3...v1.0.2
this may however missing ports of older changes, I don't know how close attention was paid to this before.
The text was updated successfully, but these errors were encountered: