Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port PyMySQL changes #720

Open
Nothing4You opened this issue Jan 30, 2022 · 2 comments
Open

Port PyMySQL changes #720

Nothing4You opened this issue Jan 30, 2022 · 2 comments
Labels
pymysql pymysql-port Awaiting or implementing port of PyMySQL change
Milestone

Comments

@Nothing4You
Copy link
Collaborator

this is a very broad scope - probably needs a review of most aiomysql code to compare with pymysql code.

a good step to start should be porting all PyMySQL test cases to see which issues we can already identify from missing test cases.
an alternative could be to review all PyMySQL commits/changes between the previously used version and the current latest version: PyMySQL/PyMySQL@v0.9.3...v1.0.2
this may however missing ports of older changes, I don't know how close attention was paid to this before.

@Nothing4You Nothing4You added pymysql pymysql-port Awaiting or implementing port of PyMySQL change labels Jan 30, 2022
@Nothing4You Nothing4You added this to the 1.0 milestone Jan 30, 2022
@Nothing4You Nothing4You modified the milestones: 0.1, 1.0 Feb 18, 2022
@alviezhang
Copy link
Contributor

alviezhang commented May 9, 2022

That is really lots of work, anything I can help to contribute for this?

@Nothing4You
Copy link
Collaborator Author

I'm not sure if there's an easy way to structure or coordinate this work, I'd be happy to hear suggestions.

One thing that should be possible to do relatively independently would be reviewing the test cases, looking into what we may be missing on our side and whether the existing test cases also test the same things.
Ensuring having all test cases on our end might also help catching some missing ports due to test failures.

Outside of tests it's probably be harder to isolate individual changes.
I'd probably just pick different methods and compare the internal logic to PyMySQL's logic, even though it is most likely quite cumbersome.

There's also still some cleanup that should be done unrelated to syncing up with PyMySQL, such as context manager simplification like aio-libs/aiopg#813, which would make the code easier to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pymysql pymysql-port Awaiting or implementing port of PyMySQL change
Projects
None yet
Development

No branches or pull requests

2 participants