Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Pydantic V2 for the CDK Manifest Models #230

Open
natikgadzhi opened this issue Jan 18, 2025 · 0 comments
Open

Migrate to Pydantic V2 for the CDK Manifest Models #230

natikgadzhi opened this issue Jan 18, 2025 · 0 comments

Comments

@natikgadzhi
Copy link
Contributor

I was tinkering around and noticed that we have this beauty of a script that makes sure that generating Python models from YAML component schema runs in Dagger of all things, because we want the OS-level dependency pinning for datamodel-codegen.

This is insane to me. We are using crazy shenanigans to avoid updating to a modern library.

We should either update to Pydantic V2 and have a normal Python or a Bash script to generate the models, or we should switch to @dataclass entirely (if we are not actively using validations).

I think @tolik0's work around refactoring the model to component factory is relevant here — it could be that this is predecessor, or vice versa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant