Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨feat(source-microsoft-sharepoint): add file transfer mode #54140

Merged

Conversation

aldogonzalez8
Copy link
Contributor

@aldogonzalez8 aldogonzalez8 commented Feb 18, 2025

What

Implement file-transfer feature for source-microsoft-sharepoint

resolves: [source-microsoft-sharepoint]: Implement file transfer

How

It updated the spec to show the option that leverages cdk logic to handle the new record type and add file_size() and get_file() to the stream reader.

image

Review guide

  1. airbyte-integrations/connectors/source-microsoft-sharepoint/source_microsoft_sharepoint/stream_reader.py: new get_file method to download file from sharepoint in chunks. Also override of _get_file_transfer_paths to get correct path from file.uri. Also, use the file_size method to get the file size as we limit 1.5 GB downloads.
  2. others: unit tests and updates on spec, documentation and connector metadata.

Tets environment on Cloud

You can find some connection testing this feature here.

image

User Impact

If they just need to move files as they are, this will greatly improve users' experience as sync will be quite fast.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 4:27pm

@aldogonzalez8 aldogonzalez8 changed the title feat(source-microsoft-sharepoint): add file transfer mode ✨feat(source-microsoft-sharepoint): add file transfer mode Feb 18, 2025
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Feb 18, 2025
@aldogonzalez8 aldogonzalez8 self-assigned this Feb 18, 2025
@@ -271,7 +271,7 @@
"required": ["filetype"]
},
{
"title": "Document File Type Format (Experimental)",
"title": "Unstructured Document Format",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This title was updated at some moment between CDK versions.

@aldogonzalez8
Copy link
Contributor Author

aldogonzalez8 commented Feb 19, 2025

/approve-regression-tests

Check job output.

✅ Approving regression tests

Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great start. Knowing we will update a few more things in sharepoint, I think it's fine to move forward.

Approving pending nits on deps and base image updates, and on green CI.

@aldogonzalez8
Copy link
Contributor Author

aldogonzalez8 commented Feb 20, 2025

/approve-regression-tests

Check job output.

✅ Approving regression tests

@aldogonzalez8 aldogonzalez8 merged commit 14e1a91 into master Feb 20, 2025
28 checks passed
@aldogonzalez8 aldogonzalez8 deleted the aldogonzalez8/source-microsoft-sharepoint/add-file-transfer branch February 20, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/microsoft-sharepoint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants