Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sgd$coefficients returns 1x* matrix and not a vector #101

Open
dustinvtran opened this issue Nov 12, 2017 · 0 comments
Open

sgd$coefficients returns 1x* matrix and not a vector #101

dustinvtran opened this issue Nov 12, 2017 · 0 comments

Comments

@dustinvtran
Copy link
Member

coef(sgd.theta) returns the vector. In general, it seems convention is to return a vector and not a matrix. Should we change sgd$coefficients to do so too? This is a user-breaking change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dustinvtran