Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Where did the Manifest object go??? #634

Closed
bcorrie opened this issue Aug 18, 2022 · 5 comments
Closed

Where did the Manifest object go??? #634

bcorrie opened this issue Aug 18, 2022 · 5 comments
Assignees
@scharch
Milestone
AIRR v1.4.0

Comments

@bcorrie
Copy link
Contributor

bcorrie commented Aug 18, 2022

I thought this was just overlooked in the Release Notes, but it is also gone from the Spec??? When did this happen?

We use this when you do a download from the iReceptor Gateway.
@bcorrie bcorrie added this to the AIRR v1.4.0 milestone Aug 18, 2022
@javh
Copy link
Contributor

javh commented Aug 18, 2022 •
edited
Loading

Are you sure it was ever in the spec?

#548 is still open and assigned to v2.

@bcorrie
Copy link
Contributor Author

bcorrie commented Aug 18, 2022

Damn, I thought it was... Oh well, we will use a future looking not yet in the spec Experimental Schema in our production Gateway I guess 8-)

@javh
Copy link
Contributor

javh commented Aug 18, 2022 •
edited
Loading

Okay. Skimming over #548 and having just messed with DataFile, I expect the final Manifest object will look different than what's in the PR, so I'd suggest implementing around that expectation. We'll need to sort out the relationship/overlap between DataFile, Manifest and RepertoireGroup/Set at some point.

@javh javh closed this as completed Aug 18, 2022
@scharch
Copy link
Contributor

scharch commented Aug 18, 2022

Looks like I missed this flash mob....

@javh
Copy link
Contributor

javh commented Aug 18, 2022 •
edited
Loading

lol. Sorry, seemed resolved. I was too quick on the tagging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scharch scharch

Labels
None yet
Projects
None yet
Milestone
AIRR v1.4.0
Development

No branches or pull requests
3 participants
@bcorrie @javh @scharch