Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R library validation does not handle properties with ontologies correctly #761

Closed
bussec opened this issue Feb 22, 2024 · 0 comments · Fixed by #762
Closed

R library validation does not handle properties with ontologies correctly #761

bussec opened this issue Feb 22, 2024 · 0 comments · Fixed by #762
Labels
Ontology Issues discussing vocabularies and ontologies

Comments

@bussec
Copy link
Member

bussec commented Feb 22, 2024

The validate_airr function of the R library fails to detect properties that are an ontology in the schema, but not a list in the data structure that is being tested.

How to reproduce

Load the bad_germline_set.json from PR #741. It should fail as GermlineSet.species is a simple string, but does not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Ontology Issues discussing vocabularies and ontologies
Projects
R Package
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add routine to validate class of an ontology object airr-community/airr-standards
1 participant
@bussec