Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign Hero Section #4

Closed
ajaynegi45 opened this issue Oct 4, 2023 · 6 comments
Closed

Redesign Hero Section #4

ajaynegi45 opened this issue Oct 4, 2023 · 6 comments

Comments

@ajaynegi45
Copy link
Owner

No description provided.

@ajaynegi45 ajaynegi45 added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Oct 4, 2023
@Sky-De
Copy link

Sky-De commented Oct 4, 2023

@ajaynegi45 hi, please assign this to me, i will fix this as soon as i receive assignment
Thanks

@ajaynegi45
Copy link
Owner Author

Assignee: @Sky-De

Hi @Sky-De ,

Thank you for your willingness to work on the "Redesign Hero Section" issue. I've just assigned the issue to you. You can now proceed with the task, and we look forward to seeing your improvements. If you have any questions or need further assistance during the process, please feel free to ask.

@Sky-De
Copy link

Sky-De commented Oct 5, 2023

@ajaynegi45 hi again, this issue is resolved, actually I just commented out the Hero component of the code and redesigned the search section, because it was better UX and UI practice to use this section rather than the Hero section,
as a result, it is ready with a great look with the minimum amount of code or structure change
I hope you like it

Gifs BEFORE and AFTER for showcases

DESKTOP--before

before-d-min

DESKTOP--after

after-d-min


MOBILE--before

before-m-min

MOBILE--after

after-m-min

If you have any questions , feel free to ask, otherwise let me know to create a PR for this issue
thanks

@ajaynegi45
Copy link
Owner Author

I don't want this hero section. I want Complete change

ex:-
Screenshot 2023-10-02 at 1 07 56 AM

@Sky-De
Copy link

Sky-De commented Oct 6, 2023

@ajaynegi45 thanks for your response
There is some points that i like to made here

  1. I believe search-book component which I've redesign is much more appealing than design you provided in term of user attraction, i highly recommend you to keep design same as i provided

  2. If you really wish change this then i have some questions about do you want to keep search-book component and then add this design as Hero section?
    Also you've used Hindi for title which i can't extract from PNG and i don't know what is that (provide that title in text here then i can copy and paste it)
    Last thing about image which you've used, does it exist within your image folder?

Last thing i highly recommend you before i change anything let me create PR then you merge it and take a look at it as live project, after that if you were not satisfied you can simply let me know and I'll change that to your desired design
Thanks

@ajaynegi45
Copy link
Owner Author

@ajaynegi45 thanks for your response There is some points that i like to made here

  1. I believe search-book component which I've redesign is much more appealing than design you provided in term of user attraction, i highly recommend you to keep design same as i provided
  2. If you really wish change this then i have some questions about do you want to keep search-book component and then add this design as Hero section?
    Also you've used Hindi for title which i can't extract from PNG and i don't know what is that (provide that title in text here then i can copy and paste it)
    Last thing about image which you've used, does it exist within your image folder?

Last thing i highly recommend you before i change anything let me create PR then you merge it and take a look at it as live project, after that if you were not satisfied you can simply let me know and I'll change that to your desired design Thanks

Create pr I will check.

#4 (comment) This is just for example purpose not for implementation.

My future plan #27 and #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants