Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better error handling #33

Open
ajenhl opened this issue May 31, 2015 · 1 comment
Open

Add better error handling #33

ajenhl opened this issue May 31, 2015 · 1 comment
Assignees
@ajenhl
Labels
enhancement

Comments

@ajenhl
Copy link
Owner

ajenhl commented May 31, 2015

Currently there are exceptions that are not handled (MemoryError with database operations, FileExistsError with corpus stripping) and should be. Also, unanticipated errors should be caught and handled generically (log exception name and message, at least).
@ajenhl ajenhl self-assigned this May 31, 2015
@ajenhl
Copy link
Owner Author

ajenhl commented Sep 17, 2016

When a database is missing entries for texts in the supplied corpus (as referenced in the supplied catalogue), a warning log message is emitted, but it should really raise an exception, since that is likely to happen later (unless the text is unlabelled in the catalogue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajenhl ajenhl

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ajenhl