Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore quoted // #18

Open
nicksbyman opened this issue Nov 3, 2018 · 0 comments
Open

Ignore quoted // #18

nicksbyman opened this issue Nov 3, 2018 · 0 comments

Comments

@nicksbyman
Copy link
Contributor

nicksbyman commented Nov 3, 2018

Noticed that the plugin takes away imports if the type is on the same line as a URL (like "http://myURL" MyDataType, and MyDataType import is taken away).

I think we could make a change to this:

'\v(//.*)@<!<' . s . '>', on line 50.

to make it work. Maybe just exclude comments that are proceeded by a quotation mark. But maybe that's not rigorous enough and we should check for the close quote too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant