-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update go/crd docs with semantic version info #2833
Comments
wrt this, I wanted to understand where this information would fit naturally Imo, Reference Docs seems as it would be more contextually relevant to developers working directly with CRDs and Go based configurations |
It turns out it is already mentioned here: kargo/api/v1alpha1/warehouse_types.go Lines 241 to 253 in 1a7ab78
(Although the comment about referring to Image Updater documentation ought to be removed. That is leftover from a time when image selection functionality was borrowed from Image Updater. That is no longer the case.) This is another spot where semver constraints are mentioned -- this time for commit selection: kargo/api/v1alpha1/warehouse_types.go Lines 137 to 146 in 1a7ab78
Run codegen after updating these comments. Edit: codegen updates the CRDs with the new comments. Eventually, those changes surface here: https://doc.crds.dev/github.com/akuity/kargo |
ref: #2521 (comment)
The text was updated successfully, but these errors were encountered: