feat: allow configuration of retry attempts for Promotion steps #2940
+657
−245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
promotion-steps-retry
branch
from
a6d7b24
to
daf4497
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we have discovered some edge cases in which a Promotion step may end up in an infinite loop, remediation to this is the ability to configure the number of (retry) attempts a step is allowed to make before bailing.
This could later be extended to waiting (or polling) configuration for steps like
git-wait-for-pr, to e.g. set a deadline in which a pull request has to be merged.Draft for now, while I iron out the actual implementation.