Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump definition does not work for function call from contract object #340

Open
polarker opened this issue Dec 22, 2024 · 5 comments
Open
Assignees

Comments

@polarker
Copy link
Member

In the following code, I can't jump to the bar function for contract foo

let foo = Foo(fooId)
foo.bar()
@polarker polarker changed the title Jump definition does not work for contract conversion Jump definition does not work for function call from contract object Dec 22, 2024
@polarker
Copy link
Member Author

This does not work either:

let foo = getFoo()
foo.bar()

@polarker
Copy link
Member Author

Sorry, the contracts I am reviewing has compilation issues. I only notice that once I run npx run compile.

Is it possible to show compiler errors to users more explicitly?

@simerplaha
Copy link
Member

Is it possible to show compiler errors to users more explicitly?

All the errors returned by invoking ralphc during parsing and compilation should already be reported explicitly.

Can we please have an example of a case where the compiler error is not being explicit? This will help us recreating it.

@polarker
Copy link
Member Author

Yes, it's reported, but not so easy to notice them. How should I check the errors?

@simerplaha
Copy link
Member

simerplaha commented Dec 24, 2024

Oh they should all be reported as regular error diagnostics. So they are highlighted red and reported in "Problems" tab. The errors reported are only the ones coming from ralphc's API here. npx run compile is not executed by ralph-lsp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants