From 1d4ce5a313d1c41e73c843587692eabebad96e00 Mon Sep 17 00:00:00 2001 From: Rachel Date: Sun, 4 Aug 2024 14:32:46 -0400 Subject: [PATCH 1/5] [bug-fix] Add padding to default markdown table cells (#2617) Default, meaning `pretty_table: false` ## Sample code ```md | First Column | Second Column | Third Column | |------------------|-----------------|----------------| | Sed in. | Sed non. | Morbi egestas. | | Donec facilisis. | Suspendisse eu. | Nulla porta. | | Praesent a. | Interdum et. | Sed nec. | ``` ### Current result current-default ### Proposed result updated-default --- _posts/2023-03-21-tables.md | 18 ++++++++++++++++-- _sass/_base.scss | 1 + 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/_posts/2023-03-21-tables.md b/_posts/2023-03-21-tables.md index da1d7e89d6a5..ca9549912a86 100644 --- a/_posts/2023-03-21-tables.md +++ b/_posts/2023-03-21-tables.md @@ -10,7 +10,17 @@ related_posts: true pretty_table: true --- -Using markdown to display tables is easy. Just use the following syntax: +Using markdown to display tables is easy. + +## Simple Example + +First, add the following to the post's front matter + +```yml +pretty_table: true +``` + +Then, the following syntax ```markdown | Left aligned | Center aligned | Right aligned | @@ -20,7 +30,7 @@ Using markdown to display tables is easy. Just use the following syntax: | Left 3 | center 3 | right 3 | ``` -That will generate: +will generate | Left aligned | Center aligned | Right aligned | | :----------- | :------------: | ------------: | @@ -30,6 +40,8 @@ That will generate:

+## HTML Example + It is also possible to use HTML to display tables. For example, the following HTML code will display a table with [Bootstrap Table](https://bootstrap-table.com/), loaded from a JSON file: {% raw %} @@ -62,6 +74,8 @@ It is also possible to use HTML to display tables. For example, the following HT

+## More Complex Example + By using [Bootstrap Table](https://bootstrap-table.com/) it is possible to create pretty complex tables, with pagination, search, and more. For example, the following HTML code will display a table, loaded from a JSON file, with pagination, search, checkboxes, and header/content alignment. For more information, check the [documentation](https://examples.bootstrap-table.com/index.html). {% raw %} diff --git a/_sass/_base.scss b/_sass/_base.scss index 1cc3372de547..6273a08d7106 100644 --- a/_sass/_base.scss +++ b/_sass/_base.scss @@ -27,6 +27,7 @@ table { td, th { font-size: 1rem; + padding: 1px 1rem 1px 0; } th { From 3be24f6b047eb6b49540a0cc1199d7e421192d9f Mon Sep 17 00:00:00 2001 From: Alon Kellner <4ubalon@gmail.com> Date: Wed, 7 Aug 2024 18:20:30 +0300 Subject: [PATCH 2/5] Alon Kellner portfolio link (#2627) I used al-folio's fork [multi-language-al-folio](https://github.com/george-gca/multi-language-al-folio) to create my portfolio, I love it :) --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 7d003a79665f..2340b685ddfa 100644 --- a/README.md +++ b/README.md @@ -144,6 +144,7 @@ Feel free to add your own page(s) by sending a PR. ★ ★ ★ +★ From 610f42bf619e2c4f43a4e19c4201e0583c4505cc Mon Sep 17 00:00:00 2001 From: George <31376482+george-gca@users.noreply.github.com> Date: Wed, 7 Aug 2024 12:40:32 -0300 Subject: [PATCH 3/5] Update Prettier information on FAQ.md --- FAQ.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/FAQ.md b/FAQ.md index 4b99439eba54..b2aa81ed1595 100644 --- a/FAQ.md +++ b/FAQ.md @@ -76,7 +76,12 @@ You need to [create a personal access token](https://docs.github.com/en/authenti ### My code runs fine locally, but when I create a commit and submit it, it fails with `prettier code formatter workflow run failed for master branch`. How do I fix that? -We implemented support for [Prettier code formatting](https://prettier.io/) in [#2048](https://github.com/alshedivat/al-folio/pull/2048). It basically ensures that your code is well formatted. If you want to ensure your code is compliant with `Prettier` you can install it in your computer [integrated with an editor](https://prettier.io/docs/en/editors), [install it and run manually](https://prettier.io/docs/en/install), or you can disable it for your repo. For this, just delete the file [.github/workflows/prettier.yml](https://github.com/alshedivat/al-folio/blob/master/.github/workflows/prettier.yml). +We implemented support for [Prettier code formatting](https://prettier.io/) in [#2048](https://github.com/alshedivat/al-folio/pull/2048). It basically ensures that your code is [well formatted](https://prettier.io/docs/en/). If you want to ensure your code is compliant with `Prettier`, you have a few options: +- if you are running locally with `Docker` and using [development containers](https://github.com/alshedivat/al-folio/blob/master/INSTALL.md#local-setup-with-development-containers), `Prettier` is already included +- if you don't use `Docker`, it is simple to integrate it with your preferred IDE using an [extension](https://prettier.io/docs/en/editors) +- if you want to run it manually, you can follow the first 2 steps in [this tutorial](https://george-gca.github.io/blog/2023/slidev_for_non_web_devs/) (`Installing node version manager (nvm)` and `Installing Node (latest version)`), then, install it using `npm install prettier` inside the project directory, or install it globally on your computer using `npm install -g prettier`. To run `Prettier` on your current directory use `npx prettier . --write`. + +You can also disable it for your repo. For this, just delete the file [.github/workflows/prettier.yml](https://github.com/alshedivat/al-folio/blob/master/.github/workflows/prettier.yml). --- From 5c5c81cda8d947d69b7ad2ec18836c006ae30367 Mon Sep 17 00:00:00 2001 From: Rachel Date: Wed, 7 Aug 2024 11:43:48 -0400 Subject: [PATCH 4/5] [Bug-fix] Make custom blockquote font coloring consistent (#2622) Currently, the tip, warning, and danger custom blockquote's font color is not customized when the text is styled as bold, italics, or a list item. As a result, the text is slightly less attractive in light mode and almost illegible in dark mode. ## Screenshot: Current current-darkmode ## Screenshot: Proposed proposed-darkmode --- _sass/_base.scss | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/_sass/_base.scss b/_sass/_base.scss index 6273a08d7106..d226dca9ab14 100644 --- a/_sass/_base.scss +++ b/_sass/_base.scss @@ -72,7 +72,10 @@ blockquote { border-color: var(--global-tip-block); background-color: var(--global-tip-block-bg); - p { + em, + li, + p, + strong { color: var(--global-tip-block-text); } @@ -90,7 +93,10 @@ blockquote { border-color: var(--global-warning-block); background-color: var(--global-warning-block-bg); - p { + em, + li, + p, + strong { color: var(--global-warning-block-text); } @@ -108,7 +114,10 @@ blockquote { border-color: var(--global-danger-block); background-color: var(--global-danger-block-bg); - p { + em, + li, + p, + strong { color: var(--global-danger-block-text); } From 04ab383c4bb4d7e653081b2f84d9e8a7ce11c097 Mon Sep 17 00:00:00 2001 From: George <31376482+george-gca@users.noreply.github.com> Date: Wed, 7 Aug 2024 13:46:07 -0300 Subject: [PATCH 5/5] Fixed prettier complaints on FAQ.md --- FAQ.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/FAQ.md b/FAQ.md index b2aa81ed1595..ac8959e35d1f 100644 --- a/FAQ.md +++ b/FAQ.md @@ -77,9 +77,10 @@ You need to [create a personal access token](https://docs.github.com/en/authenti ### My code runs fine locally, but when I create a commit and submit it, it fails with `prettier code formatter workflow run failed for master branch`. How do I fix that? We implemented support for [Prettier code formatting](https://prettier.io/) in [#2048](https://github.com/alshedivat/al-folio/pull/2048). It basically ensures that your code is [well formatted](https://prettier.io/docs/en/). If you want to ensure your code is compliant with `Prettier`, you have a few options: + - if you are running locally with `Docker` and using [development containers](https://github.com/alshedivat/al-folio/blob/master/INSTALL.md#local-setup-with-development-containers), `Prettier` is already included - if you don't use `Docker`, it is simple to integrate it with your preferred IDE using an [extension](https://prettier.io/docs/en/editors) -- if you want to run it manually, you can follow the first 2 steps in [this tutorial](https://george-gca.github.io/blog/2023/slidev_for_non_web_devs/) (`Installing node version manager (nvm)` and `Installing Node (latest version)`), then, install it using `npm install prettier` inside the project directory, or install it globally on your computer using `npm install -g prettier`. To run `Prettier` on your current directory use `npx prettier . --write`. +- if you want to run it manually, you can follow the first 2 steps in [this tutorial](https://george-gca.github.io/blog/2023/slidev_for_non_web_devs/) (`Installing node version manager (nvm)` and `Installing Node (latest version)`), then, install it using `npm install prettier` inside the project directory, or install it globally on your computer using `npm install -g prettier`. To run `Prettier` on your current directory use `npx prettier . --write`. You can also disable it for your repo. For this, just delete the file [.github/workflows/prettier.yml](https://github.com/alshedivat/al-folio/blob/master/.github/workflows/prettier.yml).