Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gnome 43 and 44 support #55

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Gnome 43 and 44 support #55

wants to merge 4 commits into from

Conversation

Lyr-7D1h
Copy link

@Lyr-7D1h Lyr-7D1h commented Jul 14, 2023 •
edited
Loading

Hi, this PR includes the changes needed to make this extension fully compatible with Gnome 43 and 44.

This pr includes:

  • Changes needed for gnome 43 and 44
  • Check for gnome version on each change
  • Formatting changes
  • Prettier settings

At the moment I can only confirm that this is fully working on Gnome 44 as this is my current working environment.
This would fix #54 #51

@Lyr-7D1h Lyr-7D1h mentioned this pull request Jul 14, 2023
Open
@Shelvak
Copy link
Contributor

Shelvak commented Jul 26, 2023

I tried to contact @alexduf without luck. I'm waiting approval from extensions team. I changed the last commit for this one Shelvak@ae915ac because I couldn't get the click open the link =(

Great work! If I get approval from gnome team, we can keep pushing improvements 🚀 I'll keep it posted here

@BRAVO68WEB
Copy link

Thank you @Lyr-7D1h, for your contribution. I installed your version manually using Git. That works great for me.

@alice-telescoop
Copy link

idem I installed it manually, thanks a lot

@petertgiles
Copy link

Thanks for posting this. I'm using it on Ubuntu 23.04 (Gnome 44.3).

@GaryElshaw
Copy link

Thank you, this had been working great for me in 44. 45 has unfortunately broken it.

SyntaxError: import declarations may only appear at top level of a module

Stack trace:
  @file:///home/gary/.local/share/gnome-shell/extensions/[email protected]/prefs.js:3:24
  _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

@benjaoming
Copy link
Contributor

@Shelvak did you hear back?

@Shelvak
Copy link
Contributor

Shelvak commented Sep 17, 2024

@Shelvak did you hear back?

No, I didn't, I ended up deleting it and enabling email notifications to be honest...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GNOME 44 Support
7 participants
@Lyr-7D1h @Shelvak @BRAVO68WEB @alice-telescoop @petertgiles @GaryElshaw @benjaoming