Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assorted improvements to the article cards and /articles/ page #931

Merged
merged 10 commits into from
Oct 28, 2024
Merged

Assorted improvements to the article cards and /articles/ page #931

merged 10 commits into from
Oct 28, 2024

Conversation

alexwlchan
Copy link
Owner

  • Article card images now have a solid colour background which matches the border, which is a placeholder shown before the card image loads in (closes Add a solid colour background to article cards before the image loads #888)
  • Article card styles are now written in vanilla CSS, not Sass (for Get rid of the Sass preprocessor and just write CSS directly #893)
  • Article card styles are only loaded on the handful of pages where they're used, not in the global stylesheet (which reduces the size of the global stylesheet by ~9%; from 13.5KB to 12.4KB)
  • Tint colours for article cards are now declared as inline variables, which slightly reduces the page size
  • The path to article card images are now a lot shorter, which reduces the size of /articles/ quite significantly (about 15%; 154.6KB to 130.9KB)
  • I removed a now-unused data-tags attribute
  • I slightly tweaked the data-date attribute to make it more compact

@alexwlchan
Copy link
Owner Author

alexwlchan commented Oct 28, 2024 •
edited
Loading

🚀 Deployed on https://672019d578a44c88769e35a9--alexwlchan.netlify.app

@alexwlchan alexwlchan temporarily deployed to pull request October 28, 2024 23:10 Inactive
@alexwlchan alexwlchan merged commit ec5cfac into main Oct 28, 2024
5 checks passed
@alexwlchan alexwlchan deleted the article-cards branch October 28, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a solid colour background to article cards before the image loads
1 participant
@alexwlchan