Lilygo tdisplay s3 and pullup resistors

[johnpaularthur]

How are you guys wiring up the board with pullup resistors? The wiring image on the mini 4/6/8 doesn't show the 10k pullup resistors. I have something similar to the mini 8 (old liquid-foot jr box), but adding a jog wheel/button. I'll have two ladders (of 4 buttons each), two expression connections, jog wheel (and button). Also hoping to have the midi ports usable somehow (separate topic). So I need at least 6 pullup resistors.

[alf45tar]

Only pins that support both input & output have integrated pull-up and pull-down resistors. Input-only GPIOs 34-39 do not.

[johnpaularthur]

hmm. then I don't know what's happening. None of my buttons are working. Logs give me these two lines (forever):

[17:25:40][202995][E][esp32-hal-adc.c:158] __analogReadRaw(): Pin 44 is not ADC pin!
[17:25:40][202996][E][esp32-hal-adc.c:158] __analogReadRaw(): Pin 43 is not ADC pin!

And this is without anything attached but the usb cable.

[johnpaularthur]

Found the issue:

The defined pins in pedalino.h are different that the connected ports schematic (rev 1.2). So i have everything wired up as the schematic and nothing is working as expected. Can I uncomment lines 116 and 117 (and comment 122 and 123), then change the led to GPIO_NUM_3? Or will this break something else?

[alf45tar]

Yes, you can but it is not suggested. The best pin assignment I found is the current one. Feel free change the pin assignment but it is up to you to find a working configuration.

Read the comment on line 121

// Analog pedals are not supported on pedal 1 and 2 because there are only 4 available GPIOs on ADC1