Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKs: Trigger build on upstream dependency change #260

Open
michaeldiamant opened this issue Dec 14, 2022 · 0 comments
Open

SDKs: Trigger build on upstream dependency change #260

michaeldiamant opened this issue Dec 14, 2022 · 0 comments

Comments

@michaeldiamant
Copy link
Contributor

michaeldiamant commented Dec 14, 2022

Problem

SDKs do not pin several dependencies, which leads to builds breaking unexpectedly. Here are the floating dependencies:

  • algorand-sdk-testing
  • generator
  • go-algorand
  • indexer
  • sandbox

We encountered a situation where changes in upstream dependencies broke SDK builds. Resolving the root issue cause took days because it took time to triage when the breaking change was introduced. Additionally, there were 2 (not 1) breaking changes. Related upstream changes:

Consequently, the story requests installing build triggers based on upstream dependency changes.

  • When one of the listed dependencies makes a change available (e.g. merge to known branch, release nightly artifact, etc), each SDK ought to run its build.
  • The intent is to isolate a breaking change, which ought to simplify triaging efforts.

Alternatively, we can pin dependencies. Doing so involves process changes. Open to discussion provided the approach accounts for keeping dependencies up-to-date.

Solution

Dependencies

Urgency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant