Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Indexer Accounting/Postgres Validations to Conduit #123

Closed
tzaffi opened this issue Jul 20, 2023 · 0 comments
Closed

Migrate Indexer Accounting/Postgres Validations to Conduit #123

tzaffi opened this issue Jul 20, 2023 · 0 comments

Comments

@tzaffi
Copy link
Contributor

tzaffi commented Jul 20, 2023

Problem

#119 introduced a small amount of data validation into the end-to-end tests. There are more intricate validations taking place in the Indexer repo: https://github.com/algorand/indexer/blame/develop/e2e_tests/src/e2e_indexer/validate_accounting.py but this is an area where conduit could improve dramatically.

Caveat

It could be argued that Conduit is most concerned with process and not so much the data specifics so that deep accounting/data validations belong elsewhere (e.g. Indexer).

Solution

This issue may be broken up into the following tasks:

  1. Survey the indexer validations to see which ones are still relevant/worth testing and which also need to stay in Indexer (for example, those testing the web API cannot be migrated)
  2. Propose new validations that are missing
  3. Add these new validations to conduit and migrate the worthwhile ones from indexer
  4. Remove the validations from Indexer

Related Epic

algorand/indexer#1550

Urgency

Medium - expanded tests should help Conduit become more pro-active in catching/preventing bugs

@algoanne algoanne closed this as not planned Won't fix, can't repro, duplicate, stale Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants