Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip questions when already bootstrapped #103

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

PhearZero
Copy link
Member

@PhearZero PhearZero commented Jan 16, 2025

ℹ Overview

Skips the bootstrap process when a node is fully configured and running

📝 Related Issues

✅ Acceptance:

  • Pre-commit checks pass

@PhearZero PhearZero added the task label Jan 16, 2025
@PhearZero PhearZero added this to the Milestone 2 milestone Jan 16, 2025
@PhearZero PhearZero self-assigned this Jan 16, 2025
@PhearZero PhearZero linked an issue Jan 16, 2025 that may be closed by this pull request
@PhearZero PhearZero requested a review from tasosbit January 16, 2025 16:35
@PhearZero PhearZero changed the base branch from main to v1.2.0 January 20, 2025 17:46
@tasosbit
Copy link
Contributor

LGTM, merge after resolving conflicts

…onally

# Conflicts:
#	cmd/bootstrap.go
#	cmd/root.go
Copy link

cloudflare-workers-and-pages bot commented Jan 21, 2025

Deploying nodekit-run with  Cloudflare Pages  Cloudflare Pages

Latest commit: 96999f4
Status: ✅  Deploy successful!
Preview URL: https://e6fd4193.nodekit-run.pages.dev
Branch Preview URL: https://chore-bootstrap-offer-fast-c.nodekit-run.pages.dev

View logs

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 63 lines in your changes missing coverage. Please review.

Please upload report for BASE (v1.2.0@a808fe2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
cmd/root.go 0.00% 40 Missing ⚠️
cmd/bootstrap.go 0.00% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             v1.2.0     #103   +/-   ##
=========================================
  Coverage          ?   46.55%           
=========================================
  Files             ?       76           
  Lines             ?     6152           
  Branches          ?        0           
=========================================
  Hits              ?     2864           
  Misses            ?     3063           
  Partials          ?      225           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PhearZero PhearZero merged commit 84b2494 into v1.2.0 Jan 21, 2025
5 of 6 checks passed
tasosbit pushed a commit that referenced this pull request Jan 22, 2025
…-fast-catchup-conditionally

chore: skip questions when already bootstrapped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧹bootstrap: offer fast-catchup conditionally
2 participants