-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: skip questions when already bootstrapped #103
Merged
PhearZero
merged 2 commits into
v1.2.0
from
chore/bootstrap-offer-fast-catchup-conditionally
Jan 21, 2025
Merged
chore: skip questions when already bootstrapped #103
PhearZero
merged 2 commits into
v1.2.0
from
chore/bootstrap-offer-fast-catchup-conditionally
Jan 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasosbit
reviewed
Jan 20, 2025
tasosbit
approved these changes
Jan 21, 2025
LGTM, merge after resolving conflicts |
…onally # Conflicts: # cmd/bootstrap.go # cmd/root.go
Deploying nodekit-run with Cloudflare Pages
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.2.0 #103 +/- ##
=========================================
Coverage ? 46.55%
=========================================
Files ? 76
Lines ? 6152
Branches ? 0
=========================================
Hits ? 2864
Misses ? 3063
Partials ? 225 ☔ View full report in Codecov by Sentry. |
tasosbit
pushed a commit
that referenced
this pull request
Jan 22, 2025
…-fast-catchup-conditionally chore: skip questions when already bootstrapped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ Overview
Skips the bootstrap process when a node is fully configured and running
📝 Related Issues
✅ Acceptance: