fix: withdraw #647
Merged
fix: withdraw #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xOneTony
commented
Aug 20, 2024
| @@ -107,6 +108,16 @@ abstract contract CoreBaseStrategy is IBaseStrategy, Transfer { | |||
| onlyPoolManager(msg.sender) | |||
| { | |||
| _beforeWithdraw(_token, _amount, _recipient); | |||
| // If the token is the pool token, revert if the amount is greater than the pool amount | |||
There was a problem hiding this comment.
In case the strategy is keeping donation tokens in the strategy then the pool managers will be able to withdraw those donation tokens, this is important to note.
There was a problem hiding this comment.
Yeah this makes sense for being the default behaviour
0xAustrian
approved these changes
Aug 20, 2024
ilpepepig
reviewed
Aug 20, 2024
ilpepepig
approved these changes
Aug 20, 2024
thelostone-mc
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure that the poolAmount is not reduced. PoolManager can withdraw non-pool tokens or excessive pool tokens.