Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add Allo.sol unit tests cases #650

Merged
merged 12 commits into from
Sep 5, 2024
Merged

Conversation

0xAustrian
Copy link

No description provided.

@0xAustrian 0xAustrian self-assigned this Aug 22, 2024
Copy link

@0xOneTony 0xOneTony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! there are some TODOs, will these get resolved in this PR? also I would like to see a command for generating the smock contracts on package.json

@0xAustrian
Copy link
Author

Looks good! there are some TODOs, will these get resolved in this PR?

Yes! I will try to fix them.

also I would like to see a command for generating the smock contracts on package.json

wdym? There is already a command smock that is called on the CI

@0xAustrian 0xAustrian requested a review from ilpepepig August 27, 2024 11:02
@0xAustrian 0xAustrian requested a review from 0xOneTony August 27, 2024 17:10
@0xOneTony 0xOneTony marked this pull request as ready for review August 29, 2024 14:34
Comment on lines 36 to 40
- name: Run Smock
run: |
bun smock
id: smock

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this step already exists

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, wrong merge maybe

@0xOneTony 0xOneTony merged commit f26eafa into v2.1 Sep 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants