Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add Allo.sol unit tests cases #650

Merged
merged 12 commits into from
Sep 5, 2024
16 changes: 8 additions & 8 deletions contracts/core/Allo.sol
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ contract Allo is IAllo, Native, Initializable, Ownable, AccessControlUpgradeable
/// percentage is 1e17 (10%), then 100 DAI will be deducted from the 1000 DAI and the pool will be
/// funded with 900 DAI. The fee is then sent to the treasury address.
/// @dev How the percentage is represented in our contracts: 1e18 = 100%, 1e17 = 10%, 1e16 = 1%, 1e15 = 0.1%
uint256 private percentFee;
uint256 internal percentFee;

/// @notice Fee Allo charges for all pools on creation
/// @dev This is different from the 'percentFee' in that this is a flat fee and not a percentage. So if you want to create a pool
Expand All @@ -55,28 +55,28 @@ contract Allo is IAllo, Native, Initializable, Ownable, AccessControlUpgradeable
uint256 internal baseFee;

/// @notice Incremental index to track the pools created
uint256 private _poolIndex;
uint256 internal _poolIndex;

/// @notice Allo treasury
address payable private treasury;
address payable internal treasury;

/// @notice Registry contract
IRegistry private registry;
IRegistry internal registry;

/// @notice Maps the `_msgSender` to a `nonce` to prevent duplicates
/// @dev '_msgSender' -> 'nonce' for cloning strategies
mapping(address => uint256) private _nonces;
mapping(address => uint256) internal _nonces;

/// @notice Maps the pool ID to the pool details
/// @dev 'Pool.id' -> 'Pool'
mapping(uint256 => Pool) private pools;
mapping(uint256 => Pool) internal pools;

/// @custom:oz-upgrades-renamed-from cloneableStrategies
mapping(address => bool) private _unusedSlot;
mapping(address => bool) internal _unusedSlot;

/// @notice The trusted forwarder contract address
/// @dev Based on ERC2771ContextUpgradeable OZ contracts
address private _trustedForwarder;
address internal _trustedForwarder;

// ====================================
// =========== Initializer =============
Expand Down
Loading
Loading