feat: add AllocationExtension.sol #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xAustrian
commented
Aug 27, 2024
There was a problem hiding this comment.
I had to create another mocks folder with a custom mock for the extension, since Smock does not work well with abstract contracts.
0xOneTony
reviewed
Aug 27, 2024
There was a problem hiding this comment.
Let's follow the example of the AlloUnit.t.sol with the naming, so it is easier as well to filter with forge only the unit tests. So we should change the file name to AllocationExtensionUnit.t.sol
ilpepepig
reviewed
Aug 27, 2024
ilpepepig
approved these changes
Aug 27, 2024
ilpepepig
reviewed
Aug 28, 2024
| // all tokens allowed | ||
| if (allowedTokens[address(0)]) return true; | ||
|
|
||
| if (allowedTokens[_token]) return true; |
There was a problem hiding this comment.
nitpick but worth ?
Suggested change
| if (allowedTokens[_token]) return true; | |
| if ( | |
| allowedTokens[address(0)] || // all tokens allowed | |
| allowedTokens[_token] | |
| ) return true; |
There was a problem hiding this comment.
Splitting the if in two instead of using || saves a bit of gas if I remember correctly.
There was a problem hiding this comment.
Because of gas saving and readability I will keep it as is.
thelostone-mc
approved these changes
Aug 28, 2024
0xOneTony
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.