Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing lower case numpy dtype field names is a "nono" #39

Open
goodboy opened this issue May 26, 2020 · 0 comments
Open

Writing lower case numpy dtype field names is a "nono" #39

goodboy opened this issue May 26, 2020 · 0 comments

Comments

@goodboy
Copy link

goodboy commented May 26, 2020

Got bit by this and documented it in alpacahq/marketstore#324. I feel that writing a test would be handy for tracking as well as maybe some protection client-side to avoid users hitting this.

2 questions:

  • should the client maybe do better error reporting from the server? Right now this is being deferred to user client code. I wonder if a flag like Client(raise_response_errors=True) would be handy?
  • There should be something in the docs stating that you can't use lower case structarray field names or even make Client.write() check for capital field names? This situation makes me think that the Client.create() approach (from Improvements #37) would allow for this without having to check in every .write() call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant