-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove boost demangle #2405
Comments
Can it be |
In general, I do not share the "remove boost at all costs" goal, so to me the new implementation needs to be at least as good as the old one, or possibly better. |
|
@fwyzard If you want, you can test it here: https://godbolt.org/z/P6MsrKTKv Update: a more advanced example with namespace: https://godbolt.org/z/159Gs313h |
Yes. My minimal example produces only 15 lines assembler including printing: https://godbolt.org/z/YhxKx6n3W |
|
It was first constexpr but in some places, it produced some issues. |
I understand, the motivation was always that boost is not testing nvcc and HIP and this produced in the past many issues. |
Note that GCC and clang produce different output in some cases, for example for gcc
clang
But maybe the old one was also doing this ? |
Ah, looks like the two give a different output for inline namespaces. inline namespace nested {
struct Type {};
}
int main(){
std::cout << "the name is: " << demangled<Type> << '\n';
} Gives: gcc
clang
|
alpaka/include/alpaka/core/DemangleTypeNames.hpp
Lines 18 to 19 in e20236d
We aim to remove boost completely. With clang 15+ and gcc 11+ we can remove this code with the following code.
These versions support
std::source_location
.The text was updated successfully, but these errors were encountered: