Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build connxr as a shared library, to enable python bindings for testing #60

Closed
nopeslide opened this issue Aug 5, 2020 · 2 comments · Fixed by #73
Closed

Build connxr as a shared library, to enable python bindings for testing #60

nopeslide opened this issue Aug 5, 2020 · 2 comments · Fixed by #73
Assignees
@alrevuelta

Comments

@nopeslide
Copy link
Collaborator

  • Python should be our way to test things
  • Having python bindings would simplify testing a lot
    • can use the onnx python library, numpy, onnxruntime etc
    • no need to generate files, everything can be done in memory
  • Central script that does all the testing
@alrevuelta
Copy link
Owner

You mean stop using CUnit and move to a Python based framework? Thumbs up for that.

@nopeslide
Copy link
Collaborator Author

You mean stop using CUnit and move to a Python based framework? Thumbs up for that.

exactly :)

@alrevuelta alrevuelta self-assigned this Sep 7, 2020
@alrevuelta alrevuelta mentioned this issue Sep 11, 2020
Merged
alrevuelta added a commit that referenced this issue Jan 10, 2021
@alrevuelta
Build as shared + Migrate testing to Python (#73)
824d494 
Migrates all testing of operators and models to Python, by building a shared library and interfacing to it from Python.
Migrates the benchmarking of models to Python. Now there is no need to use files to store the inference time.
Simplify the Makefile by moving some logic to Python.
Proof of concept before using new test data (organised by opset version and domain in #67)
Fix #60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alrevuelta alrevuelta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build as shared + Migrate testing to Python alrevuelta/cONNXr
2 participants
@alrevuelta @nopeslide