Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search textfield is not working #332

Open
anubhavpulkit opened this issue Jul 28, 2020 · 6 comments
Open

Search textfield is not working #332

anubhavpulkit opened this issue Jul 28, 2020 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@anubhavpulkit
Copy link
Contributor

Description:

The search text field of the navbar is not taking input. Inside shares when we try to tap on the search text field then Sort options pop-up.

Screen Recording:

video-to-gif-converter

@cpg cpg added the bug Something isn't working label Jul 29, 2020
@anubhavpulkit
Copy link
Contributor Author

This bug is Only present in SE 2nd generation device.

@cpg
Copy link
Member

cpg commented Jul 30, 2020

It is available in newer devices.

It is in fact a horrible implementation at this point. There are at least five or more bugs related to this:

  • unresponsive search box -- tapping on it yields no keyboard at all (nothing) or the sort selector
  • responsive box, but only in landscape mode
  • duplication or triplication of the search icon at the top right, each time a rotation happens, one new icon appears, it seems
  • appearance of a cancel button, or not. no idea how/when
  • when able to type, the search is erratic, sometimes some titles are found, sometimes not

... and quite more ..

@anubhavpulkit
Copy link
Contributor Author

Yes I found these unresponsive search box and duplication or triplication of the search icon at the top right when I'm testing in SE 2nd generation device after 2 or 3 times. But in other devices like XR, I can't find these issues.

@cpg
Copy link
Member

cpg commented Aug 6, 2020

Please list all issues here below, one by one.

Focus on fixing the first one.

Later, focus on fixing the second one.

@cpg
Copy link
Member

cpg commented Aug 8, 2020

Search works in landscape mode. That should be a very straighforward hint.

Working on colors, etc. means you are already not focused.

From my last message

  • list all the issues one by one

@anubhavpulkit
Copy link
Contributor Author

anubhavpulkit commented Aug 8, 2020

  • Unresponsive search box when tap first time(if we move to another UI controller and back again then it started working). Not responsive in any orientation.
  • Sometimes search bar worked as a sort button.
  • Duplication or triplication of the search icon at the top right in Server file UI only.
  • The issue is present only in new devices(SE 2, iPhone 11 models)
  • Appearance of a cancel button is quite random.
  • Foreground color of the text field is not changing according to different modes(always white color).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants