Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve readability of IonReaderContinuableCoreBinary.nextValue() and transcodeNextTo() #1004

Open
tgregg opened this issue Nov 27, 2024 · 1 comment
Open

Improve readability of IonReaderContinuableCoreBinary.nextValue() and transcodeNextTo() #1004

tgregg opened this issue Nov 27, 2024 · 1 comment

Comments

@tgregg
Copy link
Contributor

tgregg commented Nov 27, 2024

These are lengthy methods with looping constructs and early returns. Figuring out a better factoring would improve readability and maintainability.
@tgregg tgregg mentioned this issue Nov 27, 2024
Merged
@tgregg
Copy link
Contributor Author

tgregg commented Dec 9, 2024

Also apply this to IonReaderTextSystemX.transcodeNextTo().

Additionally, IonReaderContinuableCoreBinary.transcodeValueLiteral() and IonReaderTextSystemX.transcodeValueLiteral() are similar enough that we could consider making MacroAwareIonReader abstract and putting a generalized implementation in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tgregg