Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details entered in prosumer UI are overridden by JSON content #95

Open
nick-shaw opened this issue Oct 17, 2024 · 1 comment
Open

Details entered in prosumer UI are overridden by JSON content #95

nick-shaw opened this issue Oct 17, 2024 · 1 comment

Comments

@nick-shaw
Copy link
Collaborator

nick-shaw commented Oct 17, 2024

It may be arguable which should take precedence if there is a JSON file in the archive, and then the user enters different details in the UI. Currently what is entered in the UI is completely ignored. That is confusing for a user who may have spent time entering details and expect those to appear in the resulting CLF. Of course, in theory it is the same user who made the package with the JSON, so they should know that they have already included details there and can leave the UI blank.

Ideally when you drag in an archive with a JSON file the fields in the UI should be populated with the content of the JSON, so the user immediately knows they don't need to enter that information. It also potentially gives them an opportunity to edit it, in which case the updated information should replace that from the JSON in the generated IDT.

This is perhaps less of an issue in a real situation, but when testing with the synthetic test data the user is less likely to be familiar with the content of that data, and may be confused that the information they enter in the UI does not appear in the IDT. I was!

@nick-shaw
Copy link
Collaborator Author

In fact the values from the JSON appear to override pre-entered UI values. So for example under Advanced Options the optimisation space defaults to Oklab, and that's what you see in the UI. But synthetic_001.json says CIE Lab. So the resulting CLF says CIE Lab in the comments. Which one was actually used? It is unclear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant