Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The DCTL template still still includes a clamp at 1.0 #97

Open
nick-shaw opened this issue Oct 17, 2024 · 0 comments
Open

The DCTL template still still includes a clamp at 1.0 #97

nick-shaw opened this issue Oct 17, 2024 · 0 comments

Comments

@nick-shaw
Copy link
Collaborator

nick-shaw commented Oct 17, 2024

The _clipf() function clamps any values above 1.0:

    // Apply exposure and white balance factors
    const float Rraw = _clipf((b[0] * p_R * k) / min_b);
    const float Graw = _clipf((b[1] * p_G * k) / min_b);
    const float Braw = _clipf((b[2] * p_B * k) / min_b);

If I remember correctly an inappropriate clamp was removed from other templates in the P-2013-001 app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant