Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignored check names mismatched #1341

Open
adamchainz opened this issue Feb 1, 2023 · 2 comments
Open

Ignored check names mismatched #1341

adamchainz opened this issue Feb 1, 2023 · 2 comments
Assignees
Labels
cat: maintenance Issues and PRs related to the maintenance of a module. priority: medium Issues and PRs that should be resolved soon. status: postponed Issues and PRs that are being temporarily set aside in favour of others. type: refactor Issues and PRs related to code cleanup. version: major Issues and PRs with breaking changes belonging to the next major release.

Comments

@adamchainz
Copy link

I want to ignore leonard.exclamation.30ppm, which I tried to do by following the configuration docs, setting up my config file with:

{
    "checks": {
        "leonard.exclamation.30ppm": false
    }
}

But this does not work, the rule still appears:

$ proselint example.md
example.md:1:3: leonard.exclamation.30ppm More than 30 ppm of exclamations. Keep them under control.

After inspecting the code and seeing the rule lives in proselint.checks.typography.exclamation, I tried:

{
    "checks": {
        "typography.exclamation": false
    }
}

That does work:

$ proselint example.md

This seems like a bug since the config docs don't explain such a distinction.

It's also unfortunate that it seems you can only disable all the rules within a module - e.g. in this case I'd like to keep leonard.exclamation.multiple active.

@adamchainz adamchainz changed the title Ignored check namse mismatched Ignored check names mismatched Feb 1, 2023
@tonglil
Copy link

tonglil commented May 1, 2023

+1 the config mismatch is one of the strangest ones I've encountered.

@Nytelife26 Nytelife26 added type: refactor Issues and PRs related to code cleanup. priority: medium Issues and PRs that should be resolved soon. version: major Issues and PRs with breaking changes belonging to the next major release. status: postponed Issues and PRs that are being temporarily set aside in favour of others. cat: maintenance Issues and PRs related to the maintenance of a module. labels Apr 23, 2024
@Nytelife26 Nytelife26 self-assigned this Apr 23, 2024
@Nytelife26
Copy link
Member

Nytelife26 commented Apr 23, 2024

This will be fixed in the configuration and checks refactor, discussed in various offshoots of #1361, and previously in #1155.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: maintenance Issues and PRs related to the maintenance of a module. priority: medium Issues and PRs that should be resolved soon. status: postponed Issues and PRs that are being temporarily set aside in favour of others. type: refactor Issues and PRs related to code cleanup. version: major Issues and PRs with breaking changes belonging to the next major release.
Projects
None yet
Development

No branches or pull requests

3 participants