Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set check "typography.symbols.curly_quotes": false not working #1367

Open
cxwx opened this issue Apr 22, 2024 · 3 comments
Open

set check "typography.symbols.curly_quotes": false not working #1367

cxwx opened this issue Apr 22, 2024 · 3 comments
Assignees
Labels
cat: maintenance Issues and PRs related to the maintenance of a module. status: blocked Issues and PRs that cannot be resolved until others are.

Comments

@cxwx
Copy link

cxwx commented Apr 22, 2024

I've set ~/.config/proselint/config.json

{
  "checks": {
    "__typography.diacritical_marks": false,
    "typography.symbols.curly_quotes": false
  }
}

but still

p2.html:3:37: typography.symbols.curly_quotes Use curly quotes “”, not straight quotes "". Found 10 times elsewhere
@Nytelife26 Nytelife26 added bug: unconfirmed Bugs that need to be reproduced. type: fix Issues and PRs related to bugs. priority: high Issues and PRs that should be resolved as soon as possible. version: patch Issues and PRs with bug fixes belonging to the next patch release. status: wip Issues and PRs that are still a work in progress. cat: maintenance Issues and PRs related to the maintenance of a module. labels Apr 22, 2024
@Nytelife26 Nytelife26 self-assigned this Apr 22, 2024
@Nytelife26 Nytelife26 added status: blocked Issues and PRs that cannot be resolved until others are. and removed bug: unconfirmed Bugs that need to be reproduced. type: fix Issues and PRs related to bugs. priority: high Issues and PRs that should be resolved as soon as possible. version: patch Issues and PRs with bug fixes belonging to the next patch release. status: wip Issues and PRs that are still a work in progress. labels Apr 22, 2024
@Nytelife26
Copy link
Member

Nytelife26 commented Apr 23, 2024

Upon further investigation, it appears that this is a result of the way the configuration system presently works. Currently, it is not possible to disable individual checks within a module, only the module itself - therefore, you cannot disable typography.symbols.curly_quotes itself, but you can disable typography.symbols. This will be resolved with configuration refactoring.

@Nytelife26 Nytelife26 added this to the 1.0.0 milestone Apr 23, 2024
@luanaBanana
Copy link

Upon further investigation, it appears that this is a result of the way the configuration system presently works. Currently, it is not possible to disable individual checks within a module, only the module itself - therefore, you cannot disable typography.symbols.curly_quotes itself, but you can disable typography.symbols. This will be resolved with configuration refactoring.

I followed you suggestion but the exclusion still doesn't work.

My conifg ~/.config/proselint/config.json

{
  "checks": {
    "typography.symbols": false
  }
}

@bagder
Copy link

bagder commented Oct 17, 2024

Same here. This is a rather major bug for us as now we get false positive warnings we can't hush up.

bagder added a commit to curl/curl that referenced this issue Oct 17, 2024
Because we cannot disable the individual warnings we do not care about,
making this tool almost unusable for our purposes. See
amperser/proselint#1367

Instead, make 'very' a banned word (as recently that has been what
proselint most commonly points out for us).

Closes #15314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: maintenance Issues and PRs related to the maintenance of a module. status: blocked Issues and PRs that cannot be resolved until others are.
Projects
None yet
Development

No branches or pull requests

4 participants