Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploying specific version doesn't seem to work #105

Open
orkineric opened this issue Feb 6, 2020 · 4 comments
Open

Deploying specific version doesn't seem to work #105

orkineric opened this issue Feb 6, 2020 · 4 comments

Comments

@orkineric
Copy link

When we try to deploy a version other than latest, it seems to ignore the version and silently deploy the most recent version of the code.

@mcg1969
Copy link
Collaborator

mcg1969 commented Feb 7, 2020

Thanks, we will work on this ASAP!

@orkineric
Copy link
Author

Thanks, we will work on this ASAP!

Did this ever get addressed?

@jlstevens
Copy link
Collaborator

I just encountered the same issue in the latest release (0.4.1). I know the Python API for starting deployments does support the revision but it looks like it isn't exposed in the CLI:

ae5 deployment start --help
Usage: ae5 deployment start [OPTIONS] PROJECT
  Start a deployment for a project.
  The PROJECT identifier need not be fully specified, and may even include
  wildcards. But it must match exactly one project.
  If the static endpoint is supplied, it must be of the form
  r'[A-Za-z0-9-]+', and it will be converted to lowercase. It must not match
  any endpoint with an active deployment, nor can it match any endpoint
  claimed by another project, even if that project has no active
  deployments. If the endpoint is not supplied, it will be autogenerated
  from the project name.
  By default, this command will wait for the completion of the deployment
  creation before returning. To return more quickly, use the --no-wait
  option.
Options:
  --name TEXT              Deployment name. If not supplied, it is
                           autogenerated from the project name.
  --endpoint TEXT          Endpoint name. If not supplied, a generated
                           subdomain will be used.
  --command TEXT           The command to use for this deployment.
  --resource-profile TEXT  The resource profile to use for this deployment.
  --public / --private     Make the deployment public/private (default).
  --wait                   Wait for the deployment to complete initialization
                           before exiting.
  --stop-on-error          Stop the deployment if it fails on the first
                           attempt. Implies --wait.
  --open                   Open a browser upon initialization. Implies --wait.
  --frame                  Include the AE banner when opening.
  --help-format            Get help on the output formatting options.
  --help-filter            Get help on the row filtering options.
  --help-login             Get help on the global authentication options.
  --help                   Show this message and exit.

I would expect a --revision option which can accept a tag label or latest. This is likely an easy thing to fix so I'll see if I can get a PR in whenever I get a chance.

@mcg1969
Copy link
Collaborator

mcg1969 commented Aug 28, 2021

I know this is a very late update but I encountered an issue with deployment restart that caused it to drop the fixed version. Investigating that fix led me to conclude that this may be a documentation issue but could also benefit from a CLI change.

Specifically, AE5 actually supports a "revision" syntax where you can specific a specific version of a project by appending it to the name or ID of the project followed by a colon; e.g.

a0-ec9bca321e5047e9b6417e88e5c8510e:0.2.0
k8s:0.1.9

Supplying this to the deployment start command should allow you to fix the version number. However, I agree that a --revision option would be clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants